This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London10-StellaDelMar_RodriguezFernandez-JavaScript-Core-1-Coursework-Week4#240
Open
Stelladelmar wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
London10-StellaDelMar_RodriguezFernandez-JavaScript-Core-1-Coursework-Week4#240Stelladelmar wants to merge 4 commits intoCodeYourFuture:mainfrom
Stelladelmar wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Up to .G
from g to i. exercises
allExercises
ButcherDing
reviewed
Apr 22, 2023
| } | ||
|
|
||
| //*************************************************** | ||
|
|
There was a problem hiding this comment.
Usually we don't use ! in our arguments. Also the error code still needs to be returned (in the comments below).
ButcherDing
reviewed
Apr 22, 2023
| return students.includes(any); | ||
| } | ||
| console.log(groupIsOnlyStudents); | ||
|
|
There was a problem hiding this comment.
'any' isn't defined anywhere, and maybe rethink what is going to go inside .every().
.every() takes an array and gives us back 'true' if every element passes a certain test - this test can be a function - It looks like this is what you were trying to do.
ButcherDing
reviewed
Apr 22, 2023
|
|
||
|
|
||
| // Complete this statement | ||
|
|
Stelladelmar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will do mandatory